Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive superfluous-parens for the walrus operator #3697

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

brycepg
Copy link
Contributor

@brycepg brycepg commented Jun 16, 2020

Steps

  • Add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Skip over superfluous-parens checks for parenthesis wrapping the walrus operator since parenthesis can change the meaning of this operator

Type of Changes

Type
🐛 Bug fix
🔨 Refactoring

Related Issue

Closes #3383
Closes #3278

@brycepg brycepg changed the title Bug/issue 3383 Fix false positive superfluous-parens for the walrus operator Jun 16, 2020
@brycepg brycepg force-pushed the bug/issue-3383 branch 5 times, most recently from b972e1c to 5b017d1 Compare June 16, 2020 22:48
@coveralls
Copy link

coveralls commented Jun 16, 2020

Coverage Status

Coverage increased (+0.9%) to 90.696% when pulling 06daa92 on brycepg:bug/issue-3383 into 346bdcf on PyCQA:master.

@brycepg brycepg marked this pull request as draft June 16, 2020 23:08
@brycepg brycepg force-pushed the bug/issue-3383 branch 6 times, most recently from c8a02c7 to 454e7e1 Compare June 16, 2020 23:47
@brycepg brycepg marked this pull request as ready for review June 17, 2020 01:16
@PCManticore
Copy link
Contributor

Hey @brycepg 👋 Welcome back! Thanks for the PR and for clear commits, this has been straightforward to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants