Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less false positives for len-as-conditions (pandas's DataFrame, numpy's Array) #3821

Merged
merged 13 commits into from
Dec 31, 2020
Merged

Less false positives for len-as-conditions (pandas's DataFrame, numpy's Array) #3821

merged 13 commits into from
Dec 31, 2020

Commits on Dec 31, 2020

  1. Add new function to recover all base class of a Node

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    0c21c6e View commit details
    Browse the repository at this point in the history

  2. Restrict the number of classes affected by len-as-condition

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    57648d5 View commit details
    Browse the repository at this point in the history

  3. Handle range, generator list/dict/set comprehension

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    651660f View commit details
    Browse the repository at this point in the history

  4. Add a message in the changelog and update contributors.txt

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    00b4755 View commit details
    Browse the repository at this point in the history

  5. Add a docstring to LenChecker.base_classes_of_node 

    Following review https://github.com/PyCQA/pylint/pull/3821/files#r484553606
    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    9961c4f View commit details
    Browse the repository at this point in the history

  6. Add a comment for unclear InferenceError

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    9944264 View commit details
    Browse the repository at this point in the history

  7. Apply hippo91's suggestion for retrieving ancestors 

    More efficient, more elegant. 👌
    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    7ff76be View commit details
    Browse the repository at this point in the history

  8. Add a test for function in len() call for len_check

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    43244d6 View commit details
    Browse the repository at this point in the history

  9. Treat generator and comprehension more gracefully

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    9375cb8 View commit details
    Browse the repository at this point in the history

  10. Better and faster implementation of instance_has_bool

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    5234dae View commit details
    Browse the repository at this point in the history

  11. Add a test for function with comprehension or generator 

    Or a function returning a generator.
    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    250abec View commit details
    Browse the repository at this point in the history

  12. Use premature return to simplify the code

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    07fc0dd View commit details
    Browse the repository at this point in the history

  13. Remove test for function inference as astroid is not ready yet

    @Pierre-Sassoulas
    Pierre-Sassoulas committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    b228d77 View commit details
    Browse the repository at this point in the history