Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the documentation, fix 'magic-value-comparison' doc #7711

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Upgrade the documentation, fix 'magic-value-comparison' doc #7711

merged 1 commit into from
Nov 5, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix
✓ 📜 Docs

Description

Fix the documentation prior to reviewing #7709

@Pierre-Sassoulas Pierre-Sassoulas added Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Nov 4, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3396372398

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.381%
Totals Coverage Status
Change from base Build 3393010334: 0.0%
Covered Lines: 17241
Relevant Lines: 18076
💛 - Coveralls

cdce8p
cdce8p approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just for next time, a few more details in the description would have been nice. Something like generated with make html. 🙂

@Pierre-Sassoulas
Copy link
Member Author

Sure, sorry :) The main thing was that "magic-value-comparison" was not in the right place.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 75e84a2 into pylint-dev:main Nov 5, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the upgrade-generated-documentation branch November 5, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pierre-Sassoulas @coveralls @cdce8p