Feature: distinct Composition and Aggregation arrows

[qequ]

Type of Changes

	Type
✓	✨ New feature

Description

Update pyreverse to differentiate between compositions and aggregations in classes. Only covers the basic cases of composition and aggregation(@DudeNr33 ).

e.g. having a code like this

""" docstring for file clientmodule.py """
from data.suppliermodule_test import Interface, DoNothing, DoNothing2

class Ancestor:
    """ Ancestor method """
    __implements__ = (Interface,)
    cls_member = DoNothing()

    def __init__(self, value):
        local_variable = 0
        self.attr = 'this method shouldn\'t have a docstring'
        self.__value = value

    def get_value(self):
        """ nice docstring ;-) """
        return self.__value

    def set_value(self, value):
        self.__value = value
        return 'this method shouldn\'t have a docstring'

class Specialization(Ancestor):
    TYPE = 'final class'
    top = 'class'

    def __init__(self, value, _id, relation2: DoNothing2):
        Ancestor.__init__(self, value)
        self._id = _id
        self.relation = DoNothing()
        self.relation2 = relation2

    @classmethod
    def from_value(cls, value: int):
        return cls(value, 0, DoNothing2())

    @staticmethod
    def transform_value(value: int) -> int:
        return value * 2

    def increment_value(self) -> None:
        self.set_value(self.get_value() + 1)

without the feature

with the feature

Refs #6543

CC: @dgutson

[coveralls]

Pull Request Test Coverage Report for Build 3550691460

• 48 of 50 (96.0%) changed or added relevant lines in 4 files are covered.
• 13 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.005%) to 95.432%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pylint/pyreverse/inspector.py	30	32	93.75%

Files with Coverage Reduction	New Missed Lines	%
pylint/checkers/classes/class_checker.py	1	94.69%
pylint/checkers/refactoring/refactoring_checker.py	12	98.11%

Totals
Change from base Build 3534208420:	0.005%
Covered Lines:	17591
Relevant Lines:	18433

---

💛 - Coveralls

[DudeNr33]

Thank you very much for this contribution. This was not a trivial task, and I like the solution as it can be extended later on. 👍

@Pierre-Sassoulas Milestone 2.16.0?

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit be24c58

[DudeNr33]

@DanielNoord anything left to change from your side?

[DudeNr33]

Thank you @qequ for this enhancement!

[dgutson]

Go @qequ go!

[khashashin]

Thank you guys, great job 🎉

[jacobtylerwalls]

@DudeNr33 Gentle reminder to wipe/reduce GitHub's suggested commit message when squashing. Thanks!

[DudeNr33]

@DudeNr33 Gentle reminder to wipe/reduce GitHub's suggested commit message when squashing. Thanks!

Ah, I did not know that this is the preferred way. I'll try to remember.