Update jupyter style guide #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriolAbril
force-pushed
the
jupyter_style
branch
from
b18656a
to
72e9b90
Compare
Codecov Report
@@ Coverage Diff @@
## main #5267 +/- ##
==========================================
+ Coverage 79.17% 79.18% +0.01%
==========================================
Files 88 88
Lines 14346 14353 +7
==========================================
+ Hits 11359 11366 +7
Misses 2987 2987
|
ltoniazzi
reviewed
Dec 19, 2021
There was a problem hiding this comment.
Not sure you want to include that doc type references should use paths. Mentioning this as I struggled with it in PR 195 (see @OriolAbril reviewed on 4 Sep there), and I could not easily reach a page explaining this from the Jupyter Style Guide.
michaelosthege
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the jupyter style guide to include explanation on the extra dependencies template introduced in pymc-devs/pymc-examples#249 (already used in the glm robust with outlier detection example)