Add exclude patterns to AST rewrites #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy does some docstring manipulation in
numpy/core/overrides.pythat fails if we strip module docstrings (at least for 1.25.2, that files is significantly changed in 1.26 so it might not be an issue)This adds the ability for some file names to be excluded from AST rewriting. Currently, it's a list of filename patterns in
pyodide_pack/ast_rewrite.py, we could make this configurable later if needed. I'll look into checking if there are any other issues for Pyodide packages once #35 is merged.Also adds the bug fix for stripping docstring from a function with an empty body (initially added in #35)