Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency management pattern #5946

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Add dependency management pattern #5946

merged 2 commits into from
Jun 3, 2019

Conversation

di
Copy link
Member

@di di commented May 31, 2019

No description provided.

@di di requested a review from brainwane May 31, 2019 22:10
brainwane
brainwane suggested changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@brainwane brainwane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for this one spelling thing! Thanks for writing this up.

docs/development/patterns.rst Outdated Show resolved Hide resolved
@di di force-pushed the add-adding-dependencies-docs branch from 398b830 to 9001674 Compare June 3, 2019 19:14
@brainwane
Copy link
Contributor

I should mention - I also read this for content and it makes sense to me. :)

@di di requested a review from brainwane June 3, 2019 19:15
brainwane
brainwane approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@brainwane brainwane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🚢

@di di merged commit 2472619 into master Jun 3, 2019
@di di deleted the add-adding-dependencies-docs branch June 3, 2019 19:26
@brainwane brainwane mentioned this pull request Jun 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainwane brainwane brainwane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@di @brainwane