[BUG] enforce dtype in mask in plot_local_autocorrelation()
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add warning * add value error when mask value not in region_column
slumnitz
changed the title
mask in plot_local_autocorrelation()
jGaboardi
approved these changes
Jan 9, 2021
martinfleis
approved these changes
Jan 9, 2021
|
@martinfleis thank you for the suggestion, I removed the statement. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splot build failing on
plot_local_autocorrelation()for python v 3.7 due to change in behaviour inpandas.DataFrame.isin().For more information see #123.
maskto same type as values inregion_columnregion_columntype are not the samemasknot in the dataset