Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ABC from collections.abc for Python 3.10 compatibility. #150

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Import ABC from collections.abc for Python 3.10 compatibility. #150

merged 1 commit into from
Mar 26, 2022

Conversation

tirkarthi
Copy link
Contributor

The justification for this PR is:

Importing ABC from collections was deprecated since Python 3.4 and removed in Python 3.10 . Use collections.abc instead.

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #150 (a657d04) into main (e849359) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files          18       18           
  Lines        1226     1226           
=======================================
  Hits         1055     1055           
  Misses        171      171           
Impacted Files Coverage Δ
splot/_viz_value_by_alpha_mpl.py 96.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e849359...a657d04. Read the comment docs.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jGaboardi jGaboardi requested a review from slumnitz March 26, 2022 14:21
@martinfleis martinfleis merged commit 10fbce9 into pysal:main Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants