run 2to3 for splot #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4375896)
(cherry picked from commit 101773c)
(cherry picked from commit 545e9d3)
(cherry picked from commit bfb5703)
also removed plt.show call added __all__ dict (cherry picked from commit 1afe78b619a9424f845a28fbd5ee414637dff1d1)
also fixed type descriptors, and changed fuction to return figure instance, and made docstring conform to numpydoc standard (cherry picked from commit f546b91065e95e935acc9488f24f344b567c01d5)
(cherry picked from commit ed130d4955624b83c836b66743169e96fbef34f3)
(cherry picked from commit f6b4e9752491986f8645572faae22d85efa2036f)
also made python mapping.py show both figures (cherry picked from commit 385c835f6a52f5d9c7f6e2a89e4223868ad1b011)
(cherry picked from commit 6a8c7cd7bf1a144a2bbe6069ce87fe7df7efee88)
(cherry picked from commit f2456602c24ea8243e6d952d06fcdfadc470e700)
tests were failing now that libpysal no longer supports Python 2
See Seaborn pull request 97 for details
mapping.py can be imported now in Python 3
sjsrey
approved these changes
May 15, 2018
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapping.py can now be used in Python 3
only the last commit is new and I need it to use splot locally