Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme update #67

Merged
merged 8 commits into from
May 24, 2019
Merged

Readme update #67

merged 8 commits into from
May 24, 2019

Conversation

slumnitz
Copy link
Member

@slumnitz slumnitz commented May 21, 2019 •
edited
Loading

  • add doc and pipe badges
  • update installation instructions (Conda-forge release)
  • update dependencies to match Python 3.6 and 3.7
  • include roadmap
  • include CoC link
  • update subtitle

addresses #59

@slumnitz slumnitz requested review from jGaboardi and sjsrey May 21, 2019 22:55
@slumnitz slumnitz added this to the JOSS paper milestone May 21, 2019
jGaboardi
jGaboardi reviewed May 21, 2019
View reviewed changes
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would say to merge after correcting the several minor typos.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jGaboardi
jGaboardi reviewed May 23, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jGaboardi
jGaboardi approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let’s merge if you are ready.

@slumnitz slumnitz merged commit 19602d8 into pysal:master May 24, 2019
@slumnitz slumnitz deleted the readme-update branch March 18, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

@sjsrey sjsrey Awaiting requested review from sjsrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JOSS paper
Development

Successfully merging this pull request may close these issues.
2 participants
@slumnitz @jGaboardi