Fix format for multiple citations in JOSS paper #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple citations are separated with a `;` instead of `,` which was causing the paper to not render properly. Also fixes the missing citation of `Arribas-Bel2017` to `arribas-bel2017looking` which I assume is what was intended (feel free to change if this is wrong). Related to openjournals/joss-reviews#1838
|
Hi all, I'm not sure if this should go to the |
Awesome, thank you for helping out! The master branch is the right place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple citations are separated with a
;instead of,which wascausing the paper to not render properly. Also fixes the missing
citation of
Arribas-Bel2017toarribas-bel2017lookingwhich I assumeis what was intended (feel free to change if this is wrong).
Related to openjournals/joss-reviews#1838
Hello! Please make sure to check all these boxes before submitting a Pull Request
(PR). Once you have checked the boxes, feel free to remove all text except the
justification in point 5.
nosetestson your changes?pysal/devbranch.docstrings and
unittests?
reviewer and added relevant labels