Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting signals when not in main thread (and warn) #154

Merged
merged 5 commits into from
Sep 11, 2022
Merged

Avoid setting signals when not in main thread (and warn) #154

merged 5 commits into from
Sep 11, 2022

Conversation

altendky
Copy link
Member

@altendky altendky commented Sep 6, 2022 •
edited
Loading

#153

Draft for:

  • May also need to tell twisted to totally avoid setting signal handling.
    • based on user testing, nope

@altendky altendky mentioned this pull request Sep 6, 2022
Open
@altendky altendky marked this pull request as ready for review September 11, 2022 13:04
@altendky altendky merged commit 8dc50e9 into main Sep 11, 2022
@altendky altendky deleted the only_set_signals_in_main_thread branch September 11, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@altendky