Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: follows google's python style guide for docstrings #224

Merged
merged 1 commit into from
Feb 17, 2023
Merged

maint: follows google's python style guide for docstrings #224

merged 1 commit into from
Feb 17, 2023

Conversation

yozachar
Copy link
Collaborator

@yozachar yozachar commented Feb 16, 2023 •
edited
Loading

  • follows google's python style guide for docstrings
  • adds flake8-docstrings as dev dependency
  • update README's workflow badge
  • improves between.py and length.py scripts
  • adapts associated test cases as well
  • makes _extremes.py a private module

@yozachar yozachar added the review PR: Can be reviewed label Feb 16, 2023
@yozachar yozachar self-assigned this Feb 16, 2023
@kvesteri
Copy link
Collaborator

Can you split this PR into smaller ones? That way it is easier to review the changes.

@yozachar
Copy link
Collaborator Author

I can, but between.py, length.py and associated tests need to go together for the tests to be successful. Let me try moving other changes.

@yozachar
maint: follows Google's python style guide for docstrings
79f5f79 
- follows Google's python style guide for docstrings
- adds flake8-docstrings as dev dependency
- update README's workflow badge
@yozachar

This comment was marked as duplicate.

Sign in to view
@yozachar yozachar changed the title maint: improves between.py and length.py maint: follows google's python style guide for docstrings Feb 16, 2023
@yozachar yozachar merged commit dab3a1f into python-validators:master Feb 17, 2023
@yozachar yozachar removed the review PR: Can be reviewed label Feb 17, 2023
@yozachar yozachar added the maintenance PR: Alters existing source code label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yozachar yozachar

Labels
maintenance PR: Alters existing source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yozachar @kvesteri