Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validator TRX addresses (TRC20) #277

Closed
wants to merge 63 commits into from

Conversation

msamsami
Copy link
Contributor

This is a validator for TRC20 Tron (TRX) addresses.

@yozachar
Copy link
Collaborator

Hi @msamsami thanks for the PR.

Can you move both #276 & #277 to a folder crypto_addresses under validators, like so?

.
|---- validators
    |---- crypto_addresses
        |---- eth_address.py
        |---- trx_address.py

And do the same with their corresponding tests?

@yozachar yozachar added waiting Issue/PR: Wating for reply enhancement Issue/PR: A new feature labels Jun 12, 2023
@msamsami
Copy link
Contributor Author

Hi @joe733

Sure. I'll move btc_address.py and its test to the new directories as well.

@yozachar yozachar removed the waiting Issue/PR: Wating for reply label Jun 12, 2023
@msamsami
Copy link
Contributor Author

msamsami commented Jun 12, 2023

Hi @msamsami thanks for the PR.

Can you move both #276 & #277 to a folder crypto_addresses under validators, like so?

.
|---- validators
    |---- crypto_addresses
        |---- eth_address.py
        |---- trx_address.py

And do the same with their corresponding tests?

Hi @joe733

It's done. Please merge #276 first and then #277 to avoid any conflicts. The final structure would be like this:

.
|---- tests
    |---- crypto_addresses
        |---- __init__.py
        |---- test_btc_address.py
        |---- test_eth_address.py
        |---- test_trx_address.py

|---- validators
    |---- crypto_addresses
        |---- __init__.py
        |---- btc_address.py
        |---- eth_address.py
        |---- trx_address.py

@yozachar
Copy link
Collaborator

@msamsami please sync add-trx-validator branch from upstream.

@yozachar yozachar force-pushed the master branch 8 times, most recently from 73d540f to 0c97dde Compare August 7, 2023 08:48
@yozachar yozachar added the outdated Issue/PR: Open for more than 3 months label Nov 7, 2023
@yozachar
Copy link
Collaborator

yozachar commented Apr 4, 2024

Ref: #278 (comment)

@yozachar yozachar closed this Apr 4, 2024
@msamsami msamsami deleted the add-trx-validator branch July 2, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants