fix(recipe): fix deadlock in r/w lock recipe #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 2, 2021
westphahl
changed the title
Done. |
|
Thank you, I will first fix the CI since travis-ci.org has ceased and then take a look at your PR. |
jeffwidman
reviewed
Aug 3, 2021
westphahl
force-pushed
the
rw-deadlock
branch
from
f9d1624
to
37d3da5
Compare
|
@StephenSorriaux I rebased the fix in order to have the CI jobs running. |
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 94.44% 94.49% +0.04%
==========================================
Files 57 57
Lines 8342 8375 +33
==========================================
+ Hits 7879 7914 +35
+ Misses 463 461 -2
Continue to review full report at Codecov.
|
The lock must only consider contenders with a sequence number lower than it's own sequence number as also stated in the Zookeeper recipe description for shared locks[0]. This wasn't working correctly as the ReadLock also considered WriteLocks with a higher sequence number as contenders. This can lead to a deadlock as described in python-zk#649. [0]: https://zookeeper.apache.org/doc/r3.7.0/recipes.html#Shared+Locks Closes python-zk#649
StephenSorriaux
force-pushed
the
rw-deadlock
branch
from
37d3da5
to
884cac3
Compare
|
Mh seems like Codecov has some trouble... Will retry the jobs tomorow |
StephenSorriaux
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lock must only consider contenders with a sequence number lower than
it's own sequence number as also stated in the Zookeeper recipe
description for shared locks.
This wasn't working correctly as the ReadLock also considered WriteLocks
with a higher sequence number as contenders. This can lead to a deadlock
as described in #649.
Closes #649