Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete backup travis config #705

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

jeffwidman
Copy link
Member

@jeffwidman jeffwidman commented Jan 31, 2023

We seem pretty happy with GitHub Actions, and now that Travis is owned by PE their product seems to have gone downhill so even if we were looking for an alternative, I don't think Travis would be it. Regardless, this backup will still remain in git history, so no point in duplicating version control via .bak files.

We've seemed pretty happy with GitHub actions, and now that
Travis is owned by PE their product seems to have gone downhill
so even if we were looking for an alternative, I don't think Travis would 
be it. Regardless, this backup will still remain in git history, so no point
in duplicating version control via `.bak` files.
@jeffwidman jeffwidman changed the title refactor: delete back of travis config refactor: delete backup travis config Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 94.63% // Head: 94.49% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (acf3fe9) compared to base (8f608f8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
- Coverage   94.63%   94.49%   -0.15%     
==========================================
  Files          57       57              
  Lines        8339     8339              
==========================================
- Hits         7892     7880      -12     
- Misses        447      459      +12     
Impacted Files Coverage Δ
kazoo/tests/test_gevent_handler.py 77.46% <0.00%> (-2.12%) ⬇️
kazoo/recipe/barrier.py 97.93% <0.00%> (-2.07%) ⬇️
kazoo/recipe/queue.py 96.17% <0.00%> (-1.28%) ⬇️
kazoo/protocol/connection.py 96.07% <0.00%> (-0.62%) ⬇️
kazoo/client.py 97.76% <0.00%> (-0.48%) ⬇️
kazoo/tests/test__connection.py 97.76% <0.00%> (-0.38%) ⬇️
kazoo/tests/test_client.py 98.60% <0.00%> (-0.20%) ⬇️
kazoo/tests/test_lock.py 98.95% <0.00%> (+0.17%) ⬆️
kazoo/testing/harness.py 98.34% <0.00%> (+0.82%) ⬆️
kazoo/tests/test_eventlet_handler.py 89.61% <0.00%> (+1.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@a-ungurianu a-ungurianu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@jeffwidman jeffwidman merged commit d224a52 into master Feb 1, 2023
@jeffwidman jeffwidman deleted the jeffwidman-patch-2 branch February 1, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants