Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99108: Refresh HACL* from upstream #104401

Merged
merged 2 commits into from
May 11, 2023
Merged

gh-99108: Refresh HACL* from upstream #104401

merged 2 commits into from
May 11, 2023

Conversation

msprotz
Copy link
Contributor

@msprotz msprotz commented May 11, 2023

This PR refreshes the vendored HACL* code with an upstream version. It contains a single fix, which increases the maximum length that can be processed by SHA3. This does not affect correctness of the verified code: the previous version would simply return a "maximum length exceeded" error too soon.

This was previously not covered by the Python testsuite, so I added one for this precisely. (Tests are being added upstream, too.)

@gpshead we should definitely get this in before 3.12

@msprotz
Copy link
Contributor Author

msprotz commented May 11, 2023

I don't think this warrants a news entry but let me know if you'd like to see one.

@gpshead gpshead enabled auto-merge (squash) May 11, 2023 21:02
@gpshead gpshead merged commit 7d7dd4c into python:main May 11, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
* main:
  pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)
  pythonGH-104371: check return value of calling `mv.release` (python#104417)
  pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)
  pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)
  pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)
  pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)
  pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)
  pythongh-101819: Prepare _io._IOBase for module state (python#104386)
  pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)
  Fix refleak in `super_descr_get` (python#104408)
  pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)
  pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)
  pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)
  pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)
  pythongh-104392: Remove _paramspec_tvars from typing (python#104393)
  pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)
  pythongh-99108: Refresh HACL* from upstream (python#104401)
  pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
@msprotz msprotz deleted the protz_sha3 branch May 19, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants