Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the "pager" binary in _pyrepl #122878

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Conversation

stefanor
Copy link
Contributor

Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy

This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555

Debian (and derivatives) provide a /usr/bin/pager binary, managed by the
alternatives system, that always points to an available pager utility.
Allow _pyrepl to use it, to follow system policy

This is a very trivial change, from a patch that Debian has been
carrying since 2.7 era. Seems appropriate to upstream.
https://bugs.debian.org/799555
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IMO it's reasonable to try pager before less. On Fedora, there is no pager command, it will silently be ignored as expected which is fine.

@skirpichev
Copy link
Member

It's user-visible change, I think it worth a changelog entry.

@vstinner
Copy link
Member

@stefanor: See https://devguide.python.org/ for how to add a Changelog (NEWS) entry.

@stefanor
Copy link
Contributor Author

Added a NEWS entry.

…e-122878.4iFpsB.rst

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@vstinner vstinner enabled auto-merge (squash) September 19, 2024 12:51
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Sep 19, 2024
@vstinner vstinner merged commit 426569e into python:main Sep 19, 2024
43 checks passed
@miss-islington-app
Copy link

Thanks @stefanor for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 19, 2024
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the
alternatives system, that always points to an available pager utility.
Allow _pyrepl to use it, to follow system policy.

This is a very trivial change, from a patch that Debian has been
carrying since 2.7 era. Seems appropriate to upstream.
https://bugs.debian.org/799555
(cherry picked from commit 426569eb8ca1edaa68026aa2bab6b8d1c9105f93)

Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
@bedevere-app
Copy link

bedevere-app bot commented Sep 19, 2024

GH-124242 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 19, 2024
@stefanor stefanor deleted the pyrepl-pager branch September 19, 2024 13:21
@vstinner
Copy link
Member

Merged, thanks @stefanor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants