gh-125022: add support for simple SIMD features detection #125011
+2,322
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
commented
Oct 5, 2024
rruuaanng
reviewed
Oct 6, 2024
rruuaanng
reviewed
Oct 6, 2024
picnixz
force-pushed
the
core/simd-helpers
branch
from
b4de356
to
c33fb91
Compare
picnixz
force-pushed
the
core/simd-helpers
branch
from
c33fb91
to
3c0b4f1
Compare
picnixz
requested review from
a team,
erlend-aasland and
corona10
as code owners
picnixz
changed the title
picnixz
changed the title
|
(There are some issues I found but I haven't pushed the code yet; I'll do in a few days I think) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #124951, there has been some initial discussion on improving the performances of base64 and possibly
{bytearray,bytes,str}.translateusing SIMD instructions.More generally, if we want to use specific SIMD instructions, it'd be good if we at least know whether we can use them or not. This PR is a PoC, experimental and (hence the skip news).
Note that the detection is essentially based on what was done in the blake2 module (though the flags being detected are different in this case but we can always add all those that are needed). To prepare for a harder detection of AVX instructions support, I added all the flags that are known to CPUID and possibly relevant. Note that more work needs to be done for a production use, especially in autoconf I think.
Note
The detection of a wider large family of CPUs (here we just assume Intel for simplicity and because we don't want to be overcomplicated for now) is still an ongoing work.
cc @gpshead