Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bpo-40137: Use pep573 in functools extension module. #20055

Closed
wants to merge 2 commits into from

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented May 12, 2020

@shihai1991
Copy link
Member Author

There have a problem what petr have mentioned in #19982: This also only works because the iterator type is not subclassable.(PyType_GetModule can not work if the type is subtype).

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to subclass lru_cache_type and so calling PyType_GetModule(Py_TYPE(self)) in lru_cache_new() doesn't work.

It seems like the _functools will have to wait until the PEP 573 is extended.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shihai1991
Copy link
Member Author

It is possible to subclass lru_cache_type and so calling PyType_GetModule(Py_TYPE(self)) in lru_cache_new() doesn't work.

It seems like the _functools will have to wait until the PEP 573 is extended.

You are right, the type have tp_new can not worked now : (

@vstinner vstinner closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants