fix: Download ARM64 binary #5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runner-binaries-syncer fails with missing module "requests". Seems like in the past it worked fine without it but is now showing up as an error. Relates to pytorch/ci-infra#263. Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
The lambda runner-binaries-syncer is missing code to actually perform the download for the ARM64 binary despite having the variables in place. This change resolves that issue so that the syncer actually fetches the appropriate binary for ARM64. Closes: pytorch/ci-infra#263 Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
|
@zxiiro is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
ZainRizvi
approved these changes
Aug 20, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
The TF Lint issue doesn't appear to be anything to do with my pull request as far as I can tell. |
|
Okay I tracked it down and fixed with via #5580. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lambda runner-binaries-syncer is missing code to actually perform the
download for the ARM64 binary despite having the variables in place.
This change resolves that issue so that the syncer actually fetches
the appropriate binary for ARM64.
Closes: pytorch/ci-infra#263
Depends-On: #5569