Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #7108

Closed
wants to merge 4 commits into from
Closed

Add support for Python 3.11 #7108

wants to merge 4 commits into from

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Jan 18, 2023

Redo of #6959, because it was pushed to the main branch of the fork and I don't have permissions to push to it

@pmeier pmeier linked an issue Jan 18, 2023 that may be closed by this pull request
@pmeier
Copy link
Contributor Author

pmeier commented Jan 18, 2023

There are multiple CI failures, but as long as missing dependencies are not fixed, we can't move forward. Both numpy and scipy are currently missing 3.11 support as well. Both latest version in the channel, i.e. numpy==1.23.5 and scipy==1.9.3, have 3.11 wheels on PyPI. So I guess Anaconda needs to just build them with the newly available Python 3.11.

@johnnynunez
Copy link

There are multiple CI failures, but as long as missing dependencies are not fixed, we can't move forward. Both numpy and scipy are currently missing 3.11 support as well. Both latest version in the channel, i.e. numpy==1.23.5 and scipy==1.9.3, have 3.11 wheels on PyPI. So I guess Anaconda needs to just build them with the newly available Python 3.11.

yes, 1.24 numpy is necessary. I hope that they updated soon.

@pmeier
Copy link
Contributor Author

pmeier commented Jan 18, 2023

yes, 1.24 numpy is necessary

Why? I think they can just build 1.23.5 with Python 3.11

@johnnynunez
Copy link

yes, 1.24 numpy is necessary

Why? I think they can just build 1.23.5 with Python 3.11

yes, but it is the initial support.
But 1.24 is the released supported https://numpy.org/devdocs/release/1.24.0-notes.html

@johnnynunez
Copy link

@pmeier What packages does torchvision need? I see that Anaconda doesn't have any for python3.11. From what I've been told the release with python3.11 comes out in March, but I'm trying to press to unlock this merge much earlier

@pmeier
Copy link
Contributor Author

pmeier commented Jan 23, 2023

host:
- python
- setuptools

run:
- python
- defaults::numpy >=1.11
- requests
- libpng
- ffmpeg >=4.2 # [not win]
- jpeg
- pillow >=5.3.0, !=8.3.*
- pytorch-mutex 1.0 {{ build_variant }} # [not osx ]
{{ environ.get('CONDA_PYTORCH_CONSTRAINT') }}
{{ environ.get('CONDA_CUDATOOLKIT_CONSTRAINT', '') }}

requires:
- pytest
- scipy
- jpeg
- ca-certificates

So the Python dependencies are

  • setuptools1
  • numpy
  • requests1
  • Pillow
  • pytest1
  • scipy

but I'm trying to press to unlock this merge much earlier

Don't do that on our behalf. I agree that we need 3.11, but there is no need to push anyone for that.

Footnotes

  1. Pure Python and thus just need to be repackaged. 2 3

@johnnynunez
Copy link

@pmeier yeah of course, but it’s the next milestone/release about March aprox conda/conda#11170

@pmeier
Copy link
Contributor Author

pmeier commented Jan 23, 2023

If you have a strong need for 3.11, why not build it yourself from source?

about March aprox

We will have the branch cut for the next release in under one month (no concrete dates yet) so likely the next release will also be without 3.11. Of course nightlies will be available as soon as this PR is merged.

@osalpekar
Copy link
Member

cc @malfet @atalman

@johnnynunez
Copy link

@johnnynunez
Copy link

johnnynunez commented Mar 16, 2023

@pmeier @atalman @osalpekar ContinuumIO/anaconda-issues#13082 (comment)
Conda binaries 3.11 uploading

image

@pmeier
Copy link
Contributor Author

pmeier commented Mar 16, 2023

torchvision==0.15.1 is available for Python 3.11 from PyPI. Unfortunately, the conda version didn't make it, because the defaults channel only very recently published 3.11 versions of our dependencies. I'll open a separate issue for that. We'll provide 3.11 builds on our nightly channel soon.

@pmeier pmeier closed this Mar 16, 2023
@pmeier pmeier deleted the py311 branch May 3, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.11
5 participants