Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.tomlentirely #126

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 19, 2024

This PR drops setup.py and uses pyproject.toml only.

@mraspaud mraspaud added the bug label Mar 19, 2024
@mraspaud mraspaud requested a review from sfinkens March 19, 2024 13:48
@mraspaud mraspaud self-assigned this Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.22%. Comparing base (0cccee8) to head (a519397).

Files Patch % Lines
pygac/patmosx_coeff_reader.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   77.04%   74.22%   -2.82%     
==========================================
  Files          32       33       +1     
  Lines        3001     3115     +114     
==========================================
  Hits         2312     2312              
- Misses        689      803     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud mraspaud changed the title Fix the pypi deployment Switch to pyproject.tomlentirely Mar 19, 2024
@mraspaud mraspaud added enhancement and removed bug labels Mar 19, 2024
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot! As far as I can see there's no need to update the documentation, right? (https://pygac.readthedocs.io/en/latest/installation.html)

@mraspaud
Copy link
Member Author

The documentation should be good as it is. I just need to double check the scripts before this can be merged.

@sfinkens
Copy link
Member

You mean pygac-run? It's declared legacy in the documentation, so we could also remove it

@mraspaud
Copy link
Member Author

You mean pygac-run? It's declared legacy in the documentation, so we could also remove it

ah, good to know. But there is also pygac-convert-patmosx-coefficients which I think is still used, right?

@sfinkens
Copy link
Member

Oh right, we need that one

@sfinkens
Copy link
Member

LGTM!

@mraspaud mraspaud merged commit 298252f into pytroll:main Mar 20, 2024
5 of 8 checks passed
@mraspaud mraspaud deleted the fix-sdist-deploy branch March 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants