Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LSan for secure mode #2228

Merged
merged 10 commits into from
Oct 8, 2024
Merged

Fix LSan for secure mode #2228

merged 10 commits into from
Oct 8, 2024

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Oct 3, 2024

Referenced issues

Description of the Change

Disable LSAN for secure mode test and secure mode itself.

Possible Drawbacks

Not having LSAN is bad, but it is not able to work in secure mode because it wants to access /proc.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm marked this pull request as ready for review October 7, 2024 11:16
@Harrm Harrm requested review from xDimon and turuslan October 7, 2024 11:17
@Harrm Harrm merged commit 9c0913c into master Oct 8, 2024
17 of 22 checks passed
@Harrm Harrm deleted the fix/lsan-secure-mode branch October 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants