sender: fix SkipDeepCopySender check not working #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redHJ
reviewed
Jul 17, 2018
sender/fault_tolerant.go
Outdated
| func (ft *FtSender) SkipDeepCopy() bool { | ||
| _, ok := ft.innerSender.(SkipDeepCopySender) | ||
| return ok | ||
| } |
There was a problem hiding this comment.
fault_tolerant_test.go里可以加个测试，true和false都可以测到。pandora_sender应该就是return false的情况,mock sender就是return true的情况
|
lgtm |
wonderflow
suggested changes
Jul 17, 2018
sender/fault_tolerant.go
Outdated
| func (_ *FtSender) SkipDeepCopy() {} | ||
| func (ft *FtSender) SkipDeepCopy() bool { | ||
| _, ok := ft.innerSender.(SkipDeepCopySender) | ||
| return ok |
There was a problem hiding this comment.
ss, ok := ft.innerSender.(SkipDeepCopySender)
if ok{
return ss. SkipDeepCopy()
}
return false
wonderflow
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
优化 SkipDeepCopySender 的接口实现判断