Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to the platform generator 0.0.116 #1312

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Upgrade to the platform generator 0.0.116 #1312

merged 1 commit into from
Oct 5, 2024
+520 −455

Conversation

aloubyansky
Copy link
Member

This PR includes the following changes:

  • Upgrade the platform generator to 0.0.116;
  • change deprecated systemProperties to systemPropertyVariables in the failsafe config;
  • includes an integration test for the platform Maven plugin that creates a sample Quarkus application project and builds it.

@aloubyansky aloubyansky mentioned this pull request Oct 4, 2024
Closed
@quarkus-bot

This comment has been minimized.

Sign in to view
aloubyansky
aloubyansky commented Oct 4, 2024
View reviewed changes
pom.xml Outdated
<quarkus.platform.group-id>${dollarSign}${dollarSign}{platform.groupId}</quarkus.platform.group-id>
<quarkus.platform.version>${dollarSign}${dollarSign}{platform.version}</quarkus.platform.version>
<maven.home>${dollarSign}${dollarSign}{maven.home}</maven.home>
<quarkus.platform.maven-plugin.pom>${dollarSign}${dollarSign}{project.file.absolutePath}</quarkus.platform.maven-plugin.pom>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have added a comment, this option makes sure the POM that is used to resolve the Maven plugin artifact and its dependencies is the flattened version (.flattened-pom.xml produced by the flatten-maven-plugin when this module is built) instead of the original pom.xml.
So we run the tests using the actual artifacts that will be installed: the platform Maven plugin quarkus-maven-plugin/target/quarkus-maven-plugin-<version>.jar, quarkus-maven-plugin/.flattened-pom.xml, and the generated quarkus-bom.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed an update with a comment

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 4, 2024

Status for workflow CI Build

This is the status report for running CI Build on commit 381259a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 70a961b into quarkusio:main Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aloubyansky @gsmet