Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Qpid test version #879

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

aloubyansky
Copy link
Member

Make sure that you have run ./mvnw -Dsync and included the changes in your pull request (preferably in the same commit, unless it makes sense to do otherwise).

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 1, 2023

Failing Jobs - Building 3956cb8

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 17 #

- Failing:  

📦 Root project

Failed to execute goal io.quarkus:quarkus-platform-bom-maven-plugin:0.0.91:invoke-platform-project (build-platform-project) on project quarkus-platform-config: Failed to build the platform project, please consult the errors logged above.

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-client

io.quarkiverse.cxf.client.it.CxfClientTest.clientWithRuntimeInitializedPayload line 327 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

@aloubyansky aloubyansky merged commit 130da9c into quarkusio:main Jul 2, 2023
3 of 4 checks passed
@gemmellr
Copy link
Contributor

gemmellr commented Jul 3, 2023

Did you just update this manually? Should I be doing the same? I didnt for my PR as that seemed like it would break the PR checks the generated project is correct.

Ah, no...I see there was since an overlapping PR merged for updating the amazon bits, opened just after I opened my PR for quarkus-qpid-jms, which presumably means it fixed the 'uses wrong prop name for same resolved value' issue after my PR was raised since it changed the version of the amazon bits, so it differed from the quarkus-qpid-jms version again and the generator went back to using the correct quarkus-qpid-jms prop name after that later PR was merged (with it still using the wrong value from when my PR was merged).

Answered my own question, but I'm just going to post this comment since I've typed it :)

@aloubyansky
Copy link
Member Author

Yes, it's a known issue when there are multiple properties sharing the same value. I need to think about a better approach.

@gemmellr
Copy link
Contributor

gemmellr commented Jul 3, 2023

Yep, I recalled it coming up before which is why I didnt bother to mention it for my PR, just got curious when I saw the fix commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants