Updating documentation, refactoring reflected power interlock threshold #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
requested changes
Jan 4, 2021
Co-authored-by: Robert Jördens <rj@quartiq.de>
ryan-summers
commented
Jan 4, 2021
| uses: actions/upload-artifact@v2 | ||
| if: ${{ matrix.toolchain == 'stable' }} && | ||
| (${{ github.ref == 'refs/heads/master' }} || | ||
| ${{ github.ref == 'refs/heads/develop' }}) |
There was a problem hiding this comment.
This seems to still upload artifacts even for PRs into develop, so this may need a revisit.
There was a problem hiding this comment.
I think this is OK for now. We can restrict it once it becomes too much.
jordens
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the configurability of the reflected power interlock threshold in favor of a static configuration of 1W reflected power to protect booster hardware. Additionally, this PR updates documentation and updates the CI to archive generated release artifacts for
masteranddevelop.TODO:
This PR fixes #104
This PR fixes #109
This PR fixes #106