-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring RF channel state machine #177
Conversation
@jordens Hold off on review for this one. There's some improvements I'd like to implement first to simplify the design. |
Hmm... After playing around with the code for a while, a significant refactor of the statemachine to utilize the guards and actions provided by smlang would require us to turn the RfChannel code on it's head, as the statemachine object would own the RfChannel object instead of the other way around (as is currently implemented). |
Sounds like it may be worth it. |
Yeah, the main problem is that anything that was previously interacting with |
Don't most callers go through this single code path anyway? booster/src/hardware/booster_channels.rs Line 97 in 2501f4d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me. Let's merge now and handle remaining and arising issues later and through #178
Bench testing and button mashing indicates the statemachine is operating as I would expect it to, and I do not see a discernible difference from previous behavior. |
This PR refactors the RF channel state machine to use smlang.
This PR fixes #171