Update stm32h7 Example #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now enables the cycle counter and icache through the init::Context rather than taking the cortex_m::Peripherals. We previously were reliant on a bug in cortex_m_rtic v0.5.3 concerning being able to take the Peripherals during init. Removed dependency on external si7021 sensor, now publishes data based on internal random number generator.
Previously, the device would not reconnect to MQTT broker after restarting the program due to smoltcp trying to reuse the previous TCP connection. This was fixed in smoltcp-rs/smoltcp#367, but this change has not been released on crates.io yet, so we are pulling in a specific version of smoltcp until this is released.
Adding the cargo lockfile to make it easier for others to reproduce a working build
irwineffect
commented
Oct 23, 2020
ryan-summers
requested changes
Oct 24, 2020
Removed stm32h7-ethernet crate, now using the ethernet driver inside the stm32h7xx-hal. Reworked version specifications for RTIC and smoltcp. Added custom handling in the case the MQTT client disconnects from the broker. Removed unnecessary debug code.
| # Make dependencies use master branch for smoltcp until PR 367 lands on | ||
| # crates.io. | ||
| # https://github.com/smoltcp-rs/smoltcp/pull/367 | ||
| smoltcp = {git = "https://github.com/smoltcp-rs/smoltcp", branch = "master"} |
There was a problem hiding this comment.
For reference, I believe branch = "master" is inferred, so it's not necessary to specify.
ryan-summers
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the minimq-stm32h7 example to make it easier for others to use.
Summary of changes:
taking the cortex_m::Peripherals. We previously were reliant on a bug (
cortex_m::Peripheralssingleton can be duplicated rtic-rs/rtic#321) incortex_m_rtic v0.5.3 concerning being able to take the Peripherals during init.
internal random number generator.
program due to smoltcp trying to reuse the previous TCP connection. This was
fixed in Adjusting TCP connection 3-way handshake state management smoltcp-rs/smoltcp#367, but this change has
not been released on crates.io yet, so we are pulling in a specific version of
smoltcp until this is released.