Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use absolute path in cache file system backend #73

Merged
merged 2 commits into from
Oct 11, 2018
Merged

use absolute path in cache file system backend #73

merged 2 commits into from
Oct 11, 2018

Conversation

xhdong-umd
Copy link
Contributor

For #65

@codecov-io
Copy link

codecov-io commented Oct 11, 2018

Codecov Report

Merging #73 into master will decrease coverage by 17.82%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #73       +/-   ##
===========================================
- Coverage   76.28%   58.46%   -17.83%     
===========================================
  Files           5        5               
  Lines         194      195        +1     
===========================================
- Hits          148      114       -34     
- Misses         46       81       +35
Impacted Files Coverage Δ
R/cache_filesystem.R 100% <100%> (ø) ⬆️
R/cache_s3.R 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6ee17...b601194. Read the comment docs.

@jimhester
Copy link
Member

jimhester commented Oct 11, 2018

Can you put this before the conditional please, and add a note to NEWS.md with the fix, issue number and your GitHub username, thanks!

@xhdong-umd
Copy link
Contributor Author

If you mean to convert before line 30, it will fail when user provided a new folder name that not created yet. I put it after the folder creation specifically to avoid that.

And in the initialization of file system cache it should take current working directory with relative path, after that all the maintenance functions of the backend will use the absolute path internally so user can change working directory without problem.

@jimhester jimhester merged commit 3a06c2c into r-lib:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants