Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add viridis palette #90

Merged
merged 3 commits into from
Jun 23, 2017
Merged

Add viridis palette #90

merged 3 commits into from
Jun 23, 2017

Conversation

karawoo
Copy link
Collaborator

@karawoo karawoo commented Jun 22, 2017

Adds the viridis palette originally from ggplot2 PR.

@karawoo karawoo requested a review from hadley June 22, 2017 22:22
@hadley
Copy link
Member

hadley commented Jun 22, 2017

Directly in master, can you please do use_coverage() to get rid of the annoying codecov notification?

@r-lib r-lib deleted a comment from codecov-io Jun 22, 2017
@karawoo
Copy link
Collaborator Author

karawoo commented Jun 22, 2017

Added that and deleted the codecov comment. I can also add some tests if that would be useful, I wasn't sure what behavior we'd want to test.

hadley
hadley approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a bullet to NEWS?

  • Generally, I don't worry about updating the version in NEWS, although it's not bad to do so

  • I don't think it's worth a test given how thin a wrapper this is

@r-lib r-lib deleted a comment from codecov-io Jun 23, 2017
@r-lib r-lib deleted a comment from codecov-io Jun 23, 2017
@karawoo karawoo merged commit ed68c7b into r-lib:master Jun 23, 2017
@karawoo karawoo deleted the viridis-pal branch June 23, 2017 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karawoo @hadley