Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and cache is crs-aware & man updated #192

Merged
merged 4 commits into from
Feb 1, 2021
Merged

Fix typos and cache is crs-aware & man updated #192

merged 4 commits into from
Feb 1, 2021

Conversation

dieghernan
Copy link
Member

Following #189 and #190

  • Fix typo: dieghernan@5c7e205
  • Move comparison to string\string instead of string\integer (now it is year == "2016"). Although string\integer worked it seems just right to perform the comparison between the same data types: dieghernan@f93714b
  • Update for caching, so now it is crs-aware. I didn't spotted this one, meaning that get_eurostat_geospatial(year =2013, crs=4326) and get_eurostat_geospatial(year = 2013, crs=3857) produced the same result (since 4326 was cached in first place and 3857was updated from cache). Potential workaround is to set update_cache = FALSE).

@antagomir
Copy link
Member

Sorry @dieghernan - I only noticed this now! You could have pinged me online for this, my ignorance.. :-) Thanks so much!

@antagomir antagomir merged commit 5f92ee9 into rOpenGov:master Feb 1, 2021
@dieghernan
Copy link
Member Author

No worries!! In fact I should thank you as this was the inception of {giscoR}, my first CRAN package

@antagomir
Copy link
Member

Ok, great :D I have added you as a contributor in the DESCRIPTION file now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants