Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh datasets #246

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Refresh datasets #246

merged 3 commits into from
Dec 30, 2022

Conversation

espinielli
Copy link
Contributor

fixes #245

Copy link
Member

@antagomir antagomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

I am starting to wonder why we have decided to include these super simlple data frames as rda files instead of plain text CSVs that could be accessed with system.file() and browsed in online code more easily. But perhaps that would be another PR.

@antagomir
Copy link
Member

If you see easily how to fix the GHA failure that would be great..

@espinielli
Copy link
Contributor Author

This fails even without my changes, i.e. from a fresh clone of the repo...

@espinielli
Copy link
Contributor Author

I checked out v3.2.1 (the most recently tagged Release version) and I get errors there too...

@espinielli
Copy link
Contributor Author

espinielli commented Dec 29, 2022

CRAN on the other end says the version is 3.7.12...I am, a little bit confused by the Release numbering...aaahhh, this is from the latest on github.
BUT even this has failing testthat tests (on my platform at least: macos M1)

@espinielli
Copy link
Contributor Author

espinielli commented Dec 29, 2022

Seems good.

I am starting to wonder why we have decided to include these super simlple data frames as rda files instead of plain text CSVs that could be accessed with system.file() and browsed in online code more easily. But perhaps that would be another PR.

I agree...on the other end I would have been interested with more details of EU members/candidates, i.e. membership timeline (membership application date, Candidature acceptance date, negotiations start, membership effective date).
In a tidy data format of course, something like:

...
Norway,30 April 1962,Membership application
Norway,x Yzy 1962,Membership application vetoed
Norway,21 July 1967,Membership application
Norway,25 September 1972,Membership application withdrawn (referendum)
Norway,25 November 1992,Membership application
Norway,November 1994,Membership application withdrawn (referendum)
...

(or even better iso2a code instead of country name ;-) )

@antagomir
Copy link
Member

Ok I opened an issue.

I can approve the changes for this PR. and we have to find a fix for the builds.

If you like you can add yourself on the DESCRIPTION file contributor list (ctb) as part of this PR before we merge.

This may take until after the Xmas break at least... But if you can meanwhile find a fix, that would be greatly appreciated!

@antagomir antagomir mentioned this pull request Dec 29, 2022
@espinielli
Copy link
Contributor Author

I added myself as contributor: thanks.
I also investigated the issue with the failure (missing dict on eurostat bulk download site), see the relevant details in issue #248

@antagomir
Copy link
Member

Ok I merge this now, we must troubleshoot the other issues separately and this does not seem to affect most of the key functionality.

@antagomir antagomir merged commit 6a8fa95 into rOpenGov:master Dec 30, 2022
@antagomir
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eu_countries and eu_candidate_countries outdated
2 participants