Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new API instead of old bulk download #253

Merged
merged 12 commits into from
Feb 12, 2023
Merged

Use new API instead of old bulk download #253

merged 12 commits into from
Feb 12, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Feb 8, 2023

Addresses issues in #243 and #251. Thanks for everyone who reported problems!

  • Added a parameter to get_eurostat() that makes it possible to download data from the new dissemination API (or continue to use the old bulk download facilities as long as they still work)
  • Added new temporary functions that work with the new dissemination API
  • Added the possibility of downloading datasets with multiple frequencies
  • See NEWS.md for additional information

Any troubleshooting / testing / bug hunting is greatly appreciated!

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #253 (ddb8996) into master (1c6086c) will increase coverage by 1.16%.
The diff coverage is 61.99%.

❗ Current head ddb8996 differs from pull request most recent head d327405. Consider uploading reports for the commit d327405 to get more accurate results

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   66.05%   67.22%   +1.16%     
==========================================
  Files          22       24       +2     
  Lines         769     1022     +253     
==========================================
+ Hits          508      687     +179     
- Misses        261      335      +74     
Impacted Files Coverage Δ
R/get_eurostat_json.R 61.76% <ø> (ø)
R/get_eurostat_raw.R 76.47% <ø> (ø)
R/label_eurostat.R 54.65% <20.00%> (-33.13%) ⬇️
R/eurotime2num.R 61.36% <65.21%> (+61.36%) ⬆️
R/eurotime2date.R 54.87% <74.41%> (+21.54%) ⬆️
R/get_eurostat_raw2.R 77.77% <77.77%> (ø)
R/get_eurostat.R 52.45% <82.60%> (+12.03%) ⬆️
R/tidy_eurostat2.R 94.44% <94.44%> (ø)
R/tidy_eurostat.R 83.87% <100.00%> (+15.01%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pitkant pitkant marked this pull request as ready for review February 9, 2023 13:39
@pitkant
Copy link
Member Author

pitkant commented Feb 9, 2023

I ran devtools::check_win_release and devtools::check_win_devel tests. After fixing the few redirected or broken links there were no problems.

@antagomir antagomir merged commit 999f039 into master Feb 12, 2023
@pitkant pitkant deleted the pitkant-2 branch March 7, 2023 10:20
@pitkant pitkant mentioned this pull request Jun 26, 2023
@pitkant pitkant linked an issue Aug 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eurostat API broken
2 participants