Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require always sf for get_eurostat_geospatial() #280

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Require always sf for get_eurostat_geospatial() #280

merged 1 commit into from
Oct 20, 2023

Conversation

dieghernan
Copy link
Member

Close #279

@pitkant maybe you want to have a look first

@pitkant
Copy link
Member

pitkant commented Oct 15, 2023

Very good PR as always, thanks! I ran tests on this version with and without giscoR and sf packages and things went smoothly. I will have to check CRAN guidelines whether or not it's a problem that there's inheritDotParams from giscoR that I think causes the Rd xrefs note here:

❯ checking package dependencies ... NOTE
  Packages suggested but not available for checking: 'giscoR', 'sf'

❯ checking Rd cross-references ... NOTE
  Package unavailable to check Rd xrefs: ‘giscoR’

0 errors ✔ | 0 warnings ✔ | 2 notes ✖

R CMD check succeeded

@pitkant pitkant merged commit f68da84 into v4-dev Oct 20, 2023
@pitkant pitkant mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants