First version of getEurostatRCV with tidyr

[jhuovari]

Rewrote getEurostatRCV with tidyr

I tried a new tidyr package for getEurostatRCV and replaced the previously used melt from
reshape package. The speed improved is sizable. With “avia_goincc” data the system.time() gives
with reshape:
user system elapsed
59.52 10.15 70.41

with tidyr:
user system elapsed
0.05 0.00 0.05

Improved is probably due to dplyr that tidyr uses. Could be used also to getEurostatRaw?

The data.frame that the modified function returns is bit different from previous version. Variable columns
no longer have (row)names. It think that was duplication of information and output of str() from
that data.frame was confusing and hard to read.

Ideas:
getEurostatRCV is long and hard to remember. Better get_eurostat and make getEurostatRaw internal?
or only eurostat and remove existing eurostat-function? is stat fin version really needed?

If you accept the idea on using tidyr, mayby you should anyway merge it to some development branch, as modification will change the return value and is not tested that much.

[antagomir]

Excellent !

The whole package is in progress and no stability guarantees are given yet. So I merged straight to master branch. Let us test this during the package development process.

The data.frame that the modified function returns is bit different from previous version. Variable columns
no longer have (row)names. It think that was duplication of information and output of str() from
that data.frame was confusing and hard to read.

This seems ok.

Improved is probably due to dplyr that tidyr uses. Could be used also to getEurostatRaw?
getEurostatRCV is long and hard to remember. Better get_eurostat and make getEurostatRaw internal?

I support the idea of making the raw function internal, and optimizing its performance in the same way. Let us do when the time allows; if you have the chance to make this change you are welcome. These function names then need be changed also from Roxygen documentation and the example vignette.

or only eurostat and remove existing eurostat-function? is stat fin version really needed?

Statfin is a remnant,, perhaps not necessary any more. We have kept it for now but considering the removal. This would at least make the function naming more clear, agreed.