Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop #629

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Update rubocop #629

merged 8 commits into from
Oct 16, 2023

Conversation

santib
Copy link
Collaborator

@santib santib commented Oct 16, 2023 •
edited
Loading

  • Upgraded main rubocop gem
  • Fixed one 1 warning message
  • Fixed 6 offenses
  • Added two extensions (rubocop-minitest and rubocop-rake) that were suggested by the rubocop command
  • Upgraded rubocop-performance

TODO:

  • check new cops which are disabled by default

Output of rubocop after upgrading the gem (without any other change):
image

Output of rubocop after all changes in this PR:
image

grzuy
grzuy approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

spec/rack_attack_request_spec.rb Show resolved Hide resolved
@grzuy grzuy merged commit e9f4727 into rack:main Oct 16, 2023
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzuy grzuy grzuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santib @grzuy