Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatically run with latest ruby patch version #634

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

santib
Copy link
Collaborator

@santib santib commented Oct 25, 2023

With this change we don't need to care about patch versions

Note: I'm using strings as suggested in https://github.com/ruby/setup-ruby#supported-version-syntax. If you don't use the commas, most versions just work but 3.0 fails for some strange reason

@santib santib force-pushed the dont-specify-patch-versions-for-ruby branch from 95d35e2 to 105a254 Compare October 25, 2023 17:05
Copy link
Collaborator

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quality of life improvement!
Didn't know setup-ruby had this feature.

Thank you!

@grzuy
Copy link
Collaborator

grzuy commented Oct 26, 2023

commas,

You meant quotes I assume.

@grzuy grzuy enabled auto-merge (squash) October 26, 2023 00:20
@grzuy grzuy disabled auto-merge October 26, 2023 00:20
@grzuy grzuy changed the title Don't specify patch versions for Ruby in the CI ci: automatically run with latest ruby patch version Oct 26, 2023
@grzuy grzuy enabled auto-merge (squash) October 26, 2023 00:21
@santib
Copy link
Collaborator Author

santib commented Oct 26, 2023

commas,

You meant quotes I assume.

Yes, exactly 😅

auto-merge was automatically disabled October 26, 2023 13:52

Head branch was pushed to by a user without write access

@santib santib force-pushed the dont-specify-patch-versions-for-ruby branch from 105a254 to 6951a3e Compare October 26, 2023 13:52
@grzuy grzuy merged commit 4a68deb into rack:main Oct 26, 2023
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants