Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Added validation to CIDR blocks in Networking #33

Merged
merged 2 commits into from
Mar 14, 2024
Merged

[FIX] Added validation to CIDR blocks in Networking #33

merged 2 commits into from
Mar 14, 2024

Conversation

eva-vashkevich
Copy link
Member

No description provided.

mantis-toboggan-md
mantis-toboggan-md requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'next' button is still clickable when invalid CIDR blocks are entered; I think you need to include a check for their validity in stepConfigurationRequires

@mantis-toboggan-md mantis-toboggan-md added this to the v0.3.0 milestone Feb 13, 2024
@mantis-toboggan-md mantis-toboggan-md merged commit 49d3c26 into rancher:main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantis-toboggan-md mantis-toboggan-md mantis-toboggan-md approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eva-vashkevich @mantis-toboggan-md