[INT] Fixed pkg not building with 2.0.0 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eva-vashkevich
commented
Jul 24, 2024
eva-vashkevich
commented
- Changed how components are defined which was causing "RangeError: Maximum call stack size exceeded" error on pkg-build
- Changed id for cluster class cards to handle duplicate names
mantis-toboggan-md
requested changes
Jul 24, 2024
| export default (Vue as VueConstructor< | ||
| Vue & InstanceType<typeof CreateEditView> | ||
| >).extend({ | ||
| export default { |
There was a problem hiding this comment.
Can this use defineComponent instead? I believe we lose some vue component typing with a plain export default in components
| @@ -307,7 +304,7 @@ export default (Vue as VueConstructor< | |||
| }); | |||
| }, | |||
| clickedType(obj: {[key:string]: any}) { | |||
| this.clusterClassObj = this.clusterClasses.find((x: ClusterClass) => x.metadata.name === obj.id); | |||
| this.clusterClassObj = this.clusterClasses.find((x: ClusterClass) => x.metadata.uid === obj.id); | |||
There was a problem hiding this comment.
When I try to run yarn build-pkg capi this line throws an error because uid is not defined in the ClusterClass interface.
Is there a reason to rely on metadata.uid instead of id here? The latter would be more consistent with dashboard code generally
eva-vashkevich
force-pushed
the
shell-2.0.0
branch
from
5815761
to
a451c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.