Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add symlink for missing binary on ubuntu 22.04+ #2048

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

furlongm
Copy link
Contributor

@furlongm furlongm commented Apr 18, 2024

grub2-editenv does not exist on ubuntu 22.04+ - it is just called grub-editenv

Currently it fails like so:

ERRO[2024-04-17T22:54:28-04:00] sh: 1: grub2-editenv: not found
 : failed to run grub2-editenv /oem/grubenv set boot_assessment_check=yes: exit status 127
ERRO[2024-04-17T22:54:28-04:00] sh: 1: grub2-editenv: not found
 : failed to run grub2-editenv /oem/grubenv unset last_boot_attempt: exit status 127
ERRO[2024-04-17T22:54:28-04:00] 2 errors occurred:
        * failed to run grub2-editenv /oem/grubenv set boot_assessment_check=yes: exit status 127
        * failed to run grub2-editenv /oem/grubenv unset last_boot_attempt: exit status 127

The symlink fixes the issue

@furlongm furlongm requested a review from a team as a code owner April 18, 2024 03:09
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I think we could also check which editenv command exists and use that like we do in the bootloader code, but I will merge this in the meantime! 👍

@frelon frelon merged commit cccd838 into rancher:main Apr 18, 2024
16 checks passed
@davidcassany
Copy link
Contributor

davidcassany commented Apr 18, 2024

Very nice! I think we could also check which editenv command exists and use that like we do in the bootloader code, but I will merge this in the meantime! 👍

Interesting I guess the problem here is for the cloud-config of boot assessment, in the golang client we already check if grub2-editenv or grub-editenv should be used. I guess there is no other simple way than adding some logic in the cloud-config file to actually fallback to one or the other when a miss is detected.

@frelon this is also reminding us we should make sure all distros tests are functional. Proabably it is bit drastic but we could consider enabling them all by default, now they don't last that much and using linux we can run many concurrent jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants