Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nightly tag for ghcr.io nightly builds #2117

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Jun 26, 2024

This should always replace the latest elemental-cli image when building from main.

This change is desirable so users can reliably pull the latest tag and not have to follow the commit tags that on the other hand seem excessive.

Instead of building an image per commit, we can think about re-instating GitHub releases and build images based on git tags.

Scratch the above, since these commit tags are needed for the PR tests on OBS.
Next best thing is to add a nightly tag.

@anmazzotti anmazzotti requested a review from a team as a code owner June 26, 2024 12:52
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti changed the title Use latest tag for ghcr.io builds Use nightly tag for ghcr.io nightly builds Jun 26, 2024
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine just for the nightly.

I am wondering though if this has benefits though, as I guess this will always push a new image to the registry anyways. Probably we could just retag the already existing version, which should have been build previously on main push.

@anmazzotti anmazzotti merged commit 17a0f7b into rancher:main Jun 26, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants