Expose ELEMENTAL_CLOUD_INIT_PATHS option #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
anmazzotti
force-pushed
the
add_dynamic_configs_dir
branch
from
f908470
to
1ae89e2
Compare
ldevulder
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
--cloud-init-pathsargument for allelementalcli subcommands. This was previously added only forbuild-disk, but I find it useful in all other cases.The
ELEMENTAL_CLOUD_INIT_PATHSenv variable is also added to achieve the same effect.The reason to introduce this feature is to address corner cases when using
after-installandafter-reset, especially the latter since in the default Elemental images,/system/oemand/usr/local/cloud-configare read only, and/oemis going to be formatted before being evaluated.Having a dynamic path to be evaluated at run time allows for more freedom.
This is also an enabler for rancher/elemental-operator#806