Always write cloud config #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we be concerned about atomic writes (write to temp and move)? It is possible that you write a empty or half file to a running and valid cluster. |
|
I'm not sure I understand your question. I do think that maybe write to temp and move may be a better operation than |
|
@HighwayofLife sorry, i was just saying that both the existing code and this change would be more reliable if they used an atomic write approach. So |
HighwayofLife
force-pushed
the
write_cloud_config
branch
from
1e8e68a
to
323440b
Compare
|
@ibuildthecloud Updated with atomic-write approach. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an empty cloud config was written to the file system, which may be in the case of a previous failed deployment, subsequent runs will not write a good cloud config file. Likewise, currently any changes to a cloud config will not update existing cloud configuration. This PR allows changes to be made to a cloud config.