Warn instead of fatal if deleted host is not found in k8s. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alena1108
reviewed
Nov 30, 2017
hosts/hosts.go
Outdated
| err := k8s.CordonUncordon(kubeClient, toDeleteHost.HostnameOverride, true) | ||
| if err != nil { | ||
| if _, err := k8s.GetNode(kubeClient, toDeleteHost.HostnameOverride); err != nil { | ||
| if !apierrors.IsNotFound(err) { |
There was a problem hiding this comment.
Start with if apierrors.isNotFound, and if met, log a messgae Can't find k8s node by name []
moelsayed
force-pushed
the
check_node_bofore_delete
branch
from
e0eca94
to
3a42725
Compare
alena1108
reviewed
Nov 30, 2017
hosts/hosts.go
Outdated
| logrus.Warnf("[hosts] Can't find node by name [%s]") | ||
| return nil | ||
| } else { | ||
| return err |
There was a problem hiding this comment.
I don't think there is a need for else. Just return err
moelsayed
force-pushed
the
check_node_bofore_delete
branch
from
3a42725
to
9e50f0d
Compare
hosts/hosts.go
Outdated
| if !apierrors.IsNotFound(err) { | ||
| return err | ||
| } else { | ||
| logrus.Warnf("[hosts] Host [%s] is not a Kubernetes node") |
There was a problem hiding this comment.
specify the host name for %s
moelsayed
force-pushed
the
check_node_bofore_delete
branch
from
9e50f0d
to
30eb95c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#70