fix(ingest/looker): skip empty user ids for usage (datahub-project#7686)

rapid7 · Mar 27, 2023 · a954edf · a954edf
1 parent d3b2830
commit a954edf
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py b/metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py
@@ -1067,12 +1067,13 @@ def create_looker_user(cls, raw_user: User) -> "LookerUser":
         )
 
     def get_urn(self, strip_user_ids_from_email: bool) -> Optional[str]:
-        if self.email is None:
+        user = self.email
+        if user and strip_user_ids_from_email:
+            user = user.split("@")[0]
+
+        if not user:
             return None
-        if strip_user_ids_from_email:
-            return builder.make_user_urn(self.email.split("@")[0])
-        else:
-            return builder.make_user_urn(self.email)
+        return builder.make_user_urn(user)
 
 
 @dataclass