Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Python / Ubuntu version support changes from RSNs 22, 23, 24, 25. #21

Merged
merged 6 commits into from
Dec 8, 2022
Merged

Apply Python / Ubuntu version support changes from RSNs 22, 23, 24, 25. #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd9c662
Apply Python / Ubuntu version support changes from RSNs 22, 23, 24, 25.
bdice Nov 21, 2022
35c9a60
update axis
ajschmidt8 Dec 7, 2022
5ab55be
exclude ubuntu18 & cuda 11.8
ajschmidt8 Dec 7, 2022
852944b
Revert "exclude ubuntu18 & cuda 11.8"
ajschmidt8 Dec 7, 2022
e9c2317
add script to compute image architectures
ajschmidt8 Dec 8, 2022
c57e845
update `compute-arch.sh`
ajschmidt8 Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions .github/workflows/build-and-publish-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,10 @@ jobs:
echo "TAGS=${TAGS}" >> ${GITHUB_OUTPUT}
- name: Compute Platforms
id: compute-platforms
run: |
set -x
PLATFORMS="linux/amd64"

if [[
"${{ matrix.CUDA_VER }}" > "11.2.2" &&
"${{ matrix.LINUX_VER }}" != "centos7"
]]; then
PLATFORMS+=",linux/arm64"
fi
echo "PLATFORMS=${PLATFORMS}" >> ${GITHUB_OUTPUT}
run: ./ci/compute-arch.sh
env:
CUDA_VER: ${{ matrix.CUDA_VER }}
LINUX_VER: ${{ matrix.LINUX_VER }}
- name: Build and push
timeout-minutes: 30
uses: docker/build-push-action@v3
Expand Down
14 changes: 12 additions & 2 deletions axis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
CUDA_VER:
- "11.5.1"
- "11.4.1"
- "11.2.2"
- "11.4.1"
- "11.5.1"
- "11.8.0"
PYTHON_VER:
- "3.8"
- "3.9"
- "3.10"
LINUX_VER:
- "ubuntu18.04"
- "ubuntu20.04"
- "ubuntu22.04"
- "centos7"
- "rockylinux8"
exclude:
- LINUX_VER: "ubuntu22.04"
CUDA_VER: "11.2.2"
- LINUX_VER: "ubuntu22.04"
CUDA_VER: "11.4.1"
- LINUX_VER: "ubuntu22.04"
CUDA_VER: "11.5.1"
35 changes: 35 additions & 0 deletions ci/compute-arch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/bin/bash
# Script to determine which image architectures should
# be built for different CUDA/OS variants.
# Example Usage:
# CUDA_VER=11.5.1 LINUX_VER=centos8 ./ci/compute-arch.sh
set -eu

PLATFORMS="linux/amd64"

write_platforms() {
local PLATFORMS="${1}"

# Use /dev/null to ensure the script can be tested locally
echo "PLATFORMS=${PLATFORMS}" | tee --append "${GITHUB_OUTPUT:-/dev/null}"
}

# Ubuntu18.04 and RockyLinux8 images don't officially support arm.
# Even though Ubuntu18.04 and RockyLinux8 images prior to CUDA 11.8.0 did
# have arm variants, they were removed for 11.8.0.
if [[
"${CUDA_VER}" == "11.8.0" &&
("${LINUX_VER}" == "ubuntu18.04" || "${LINUX_VER}" == "rockylinux8")
]]; then
write_platforms "${PLATFORMS}"
exit 0
fi

if [[
"${CUDA_VER}" > "11.2.2" &&
"${LINUX_VER}" != "centos7"
]]; then
PLATFORMS+=",linux/arm64"
fi

write_platforms "${PLATFORMS}"