Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make custom build backend work in legacy-editable mode #12827

Closed
wants to merge 1 commit into from
Closed

Make custom build backend work in legacy-editable mode #12827

wants to merge 1 commit into from

Conversation

trxcllnt
Copy link
Contributor

Not entirely sure how setuptools uses the custom build backend, but this PR makes editable installs work when doing:

SETUPTOOLS_ENABLE_FEATURES="legacy-editable" \
pip install --no-build-isolation --no-deps --editable .

@trxcllnt trxcllnt requested a review from a team as a code owner February 22, 2023 20:02
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 22, 2023
@trxcllnt trxcllnt requested a review from vyasr February 22, 2023 20:02
@trxcllnt trxcllnt added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 22, 2023
@trxcllnt trxcllnt force-pushed the fix/cudf-python-backend-editable branch from 55e4dc2 to f5bbabe Compare February 22, 2023 20:04
@vyasr
Copy link
Contributor

vyasr commented Feb 23, 2023

@trxcllnt could you try again with the latest branch-23.04? #12741 should make this change unnecessary.

@trxcllnt
Copy link
Contributor Author

Yeah I'll give it a shot

@trxcllnt trxcllnt closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trxcllnt @vyasr